Skip to content

opengl shader fixes and an xcode fix #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrentDaMage merged 2 commits into from
Jan 5, 2026
Merged

opengl shader fixes and an xcode fix #243

BrentDaMage merged 2 commits into from
Jan 5, 2026

Conversation

@Un1q32
Copy link
Contributor

@Un1q32 Un1q32 commented Jan 1, 2026 •
edited
Loading

ignore the comments the original pr was scrapped

BrentDaMage
BrentDaMage requested changes Jan 4, 2026
View reviewed changes
Copy link
Collaborator

@BrentDaMage BrentDaMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull from upstream. Once done, I'll test on my Power Mac G5 to make sure it still builds properly there. Code-wise, LGTM.

@Un1q32 Un1q32 marked this pull request as draft January 4, 2026 03:34
@Un1q32 Un1q32 marked this pull request as ready for review January 4, 2026 03:37
@Un1q32
Copy link
Contributor Author

Un1q32 commented Jan 4, 2026

Had to redo the xcode part cuz it still referenced libz.tbd for some reason, should be all good now.

BrentDaMage
BrentDaMage approved these changes Jan 4, 2026
View reviewed changes
Copy link
Collaborator

@BrentDaMage BrentDaMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BrentDaMage
BrentDaMage requested changes Jan 4, 2026
View reviewed changes
Copy link
Collaborator

@BrentDaMage BrentDaMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails for iOS on Xcode. Says something about not being able to find _deflate and others when linking.

@Un1q32
Copy link
Contributor Author

Un1q32 commented Jan 4, 2026

Didn't realize the iOS build also built it's own zlib, cmake build has always linked system zlib.

@BrentDaMage
Copy link
Collaborator

BrentDaMage commented Jan 4, 2026

Encountering the exact same issue. It's trying to link to a 32-bit version of the library, but there isn't one present on 10.8.5 I guess. It's looking in /opt/local/lib

@Un1q32
Copy link
Contributor Author

Un1q32 commented Jan 5, 2026

Encountering the exact same issue. It's trying to link to a 32-bit version of the library, but there isn't one present on 10.8.5 I guess. It's looking in /opt/local/lib

There always is in the SDK, it might be finding a macports zlib at /opt/local/lib/libz.dylib that overrides it, the solution would be to manually ensure that the SDKs lib folder is higher in the search path, but IDK how to do that from Xcode.

@Un1q32
Copy link
Contributor Author

Un1q32 commented Jan 5, 2026

nvm figured it out

@Un1q32 Un1q32 force-pushed the zlib branch 2 times, most recently from 1fa345f to e8be8dc Compare January 5, 2026 00:50
@Un1q32 Un1q32 force-pushed the zlib branch 3 times, most recently from e1b3c7f to e6051b1 Compare January 5, 2026 01:17
@Un1q32 Un1q32 changed the title zlib changes opengl shader fixes and an xcode fix Jan 5, 2026
@BrentDaMage BrentDaMage merged commit dc84a54 into ReMinecraftPE:master Jan 5, 2026
22 checks passed
@Un1q32 Un1q32 deleted the zlib branch January 5, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrentDaMage BrentDaMage BrentDaMage approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Un1q32 @BrentDaMage